Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

updates mintedsecret in bucketaccess to secret reference #39

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

krishchow
Copy link

@krishchow krishchow commented Apr 16, 2021

This PR changes the mintedSecretName to a mintedSecret Secret Reference. This is mainly done so we have a reference to the namespace of the secret, which will be created in the same namespace as the provisioner (dynamic)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot requested review from rrati and xing-yang April 16, 2021 21:39
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2021
@krishchow krishchow changed the title updates mintedsecret in bucketaccess to object reference updates mintedsecret in bucketaccess to secret reference Apr 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishchow, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wlan0
Copy link
Contributor

wlan0 commented Apr 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0af83d5 into kubernetes-retired:master Apr 17, 2021
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
…se-tools

Update go version in release tools
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants